amitbl / blocktube

YouTube™ content blocker
GNU General Public License v3.0
945 stars 67 forks source link

BlockTube is gone from the Firefox Add-ons website #281

Closed FoxBlocks closed 1 year ago

FoxBlocks commented 1 year ago

What happened to it? Why is it not up for download anymore?

amitbl commented 1 year ago

Mozilla decided after 5 years of activity to disable the addon and sent me this:

This add-on didn't pass review because of the following problems:

1) Your add-on contains minified, concatenated or otherwise machine-generated code. If you haven't done so, you need to provide the original sources, together with instructions on how to generate the exact same code used in the add-on. Source code must be provided as an archive and uploaded using the source code upload field, which can be done during submission or on the version page in the developer hub. Please read through the instructions at https://extensionworkshop.com/documentation/publish/source-code-submission/ .

blocktube-master\src\ui\cm

2) ‘eval’ is only necessary in rare cases. Please use a different method or explain why eval is required in your add-on.

blocktube-master\src\scripts\inject.js - line 1117

In short, they have a problem with the compressed text editor code and the usage of the eval function related to the advanced blocking feature of the extension I replaced the compressed code with the original one, and explained the usage of this function. The addon is now pending review and hopefully will be back soon

FoxBlocks commented 1 year ago

I see. Thanks for letting me know!

OrangeColaJuice commented 1 year ago

It's taking ages on their part... can you please provide us with an addon file to use in unsigned builds, like the official one or librewolf.

amitbl commented 1 year ago

For anyone interested, check out the updated install section for installing the extension in the meantime. Please note it will only work on ESR/Developer/Nightly versions of Firefox https://github.com/amitbl/blocktube#install

amitbl commented 1 year ago

They reviewed the extension and once again sent:

This add-on didn't pass review because of the following problems:

1) ‘eval’ is only necessary in rare cases. Please use a different method or explain why eval is required in your add-on.

blocktube-master\src\scripts\inject.js - line 1117

Where does the description of the addon specify this custom script functionality?
tazihad commented 1 year ago

I reinstalled os. And bam. My one of the most favourite add on is gone. I hope you update the addon to keep it in store.

NicoTheCinderace commented 1 year ago

I genuinely hope this issue gets resolved soon.

FoxBlocks commented 1 year ago

I'm not sure if this will work for everyone, but what worked for me is going to an old snapshot of the extension page on the Wayback Machine and installing it from there.

tazihad commented 1 year ago

@FoxBlocks Can you share the directlink? I can't install xpi. It shows corrupted. EDIT: Found it. Looks like I had to wait in save as page in kde. If I don't do it file doesn't download complete. https://web.archive.org/web/20230207005146/https://addons.mozilla.org/en-US/firefox/addon/blocktube/

ghost commented 1 year ago

Didn't work for me when trying to download from Firefox itself, I had to use wget https://web.archive.org/web/20230207005146/https://addons.mozilla.org/firefox/downloads/file/4024189/blocktube-0.3.32.xpi and select "Install extension from file", you can also try opening in another browser to download.

amitbl commented 1 year ago

And again...

This add-on didn't pass review because of the following problems:

1)  ‘eval’ is only necessary in rare cases. Please use a different method or explain why eval is required in your add-on.

blocktube-master\src\scripts\inject.js - line 1117

Alternatively, you can use window.eval.

Waiting for another review..

amitbl commented 1 year ago

The addon is finally listed again :partying_face: