search

amitbl / blocktube

YouTube™ content blocker
GNU General Public License v3.0
960 stars 67 forks source link

blocktube stopped working on firefox #449

Open geextahslex opened 2 months ago

geextahslex commented 2 months ago

Hi, blocktube stopped working on firefox since 9.9.24 There must have been a change on youtube side because also other addons needed update to work properly.

I mean it doesn't work when you are watching the video. It still works when you are on a youtube channel videos page

direct video doesn't work 232323

youtube channel videos page does work 232323 efe

josephcrowell commented 2 months ago

tracelog when attepting to block the channel on the video page: 

Uncaught TypeError: document.getElementsByTagName(...)[0].data is undefined
    menuOnTap moz-extension://c3c8151d-6ad9-4f30-a35d-7b209a3f4357/src/scripts/inject.js:1522
    menuOnTap https://www.youtube.com/watch?v=fOIrB1fwVPc:2
    connectedCallback https://www.youtube.com/watch?v=fOIrB1fwVPc:2
    insertBefore https://www.youtube.com/s/desktop/f8d5cd66/jsbin/desktop_polymer.vflset/desktop_polymer.js:7216
    Ib https://www.youtube.com/s/desktop/f8d5cd66/jsbin/webcomponents-sd.vflset/webcomponents-sd.js:113
    Ya https://www.youtube.com/s/desktop/f8d5cd66/jsbin/webcomponents-sd.vflset/webcomponents-sd.js:111
    _renderSelf https://www.youtube.com/s/desktop/f8d5cd66/jsbin/webcomponents-sd.vflset/webcomponents-sd.js:108
    W https://www.youtube.com/s/desktop/f8d5cd66/jsbin/webcomponents-sd.vflset/webcomponents-sd.js:107
    s https://www.youtube.com/s/desktop/f8d5cd66/jsbin/webcomponents-sd.vflset/webcomponents-sd.js:106

Looks like the ytd-page-manager tag's first child element doesn't have any data attributes now.

geextahslex commented 2 months ago

Yeah hopefully there will be an update soon

josephcrowell commented 2 months ago

This fixes it: https://github.com/amitbl/blocktube/pull/453

geextahslex commented 2 months ago

@josephcrowell Awesome :) How do I use/apply it? I looked for inject.js in my firefox folder but I can't find it.

JonJonsonsSon commented 2 months ago

Bump, can confirm this add-on has stopped working in waterfox (a fork of firefox) too for quite some time

josephcrowell commented 2 months ago

Here you go folks: https://addons.mozilla.org/en-US/firefox/addon/youtube-content-blocker/

This is a new version of this add on with a few fixes from various members added in.

josephcrowell commented 2 months ago

Before switching to the new plugin, export your config and uninstall the old plugin. Then import the config in the new plugin.

They can't be installed at the same time because their files conflict with each other.

geextahslex commented 2 months ago

@josephcrowell YouTube Content Blocker works flawless, thank you for that :) I left a comment on mozilla

The latest blocktube update 0.4.3 didn't fix anything, on the contrary, it completely removed the "block video" options. Nothing more to say at that point

JonJonsonsSon commented 1 month ago

Here you go folks: https://addons.mozilla.org/en-US/firefox/addon/youtube-content-blocker/

This is a new version of this add on with a few fixes from various members added in.

Bumping to draw attention to this. Tyvm for all your work!