Project Feedback

[amitch6097]

@chrisvfritz Can you take a look at this? It's hosted here and meets the following criteria:

• [x] Use this base HTML (feel free to change it) to build a simple app that generates the HTML for a dating profile in this format, using information collected from the user
• [x] Show a preview of the dating profile with rendered HTML (e.g. <em>hella charming</em> should appear as hella charming)
• [x] Also show the raw, generated HTML inside the <pre><code></code></pre> elements (e.g. <em>hella charming</em> should appear as <em>hella charming</em>)
• [x] Both the preview and raw HTML should update live as the user enters their information
• [x] All JavaScript is in a separate .js file

[chrisvfritz]

Wow, some things I 😍 :

• No duplication 🍪
• Great commit messages 🍰
• Descriptive comments 🍭

😂 These are tears of joy! The only areas of improvement I see are:

• I'm seeing some style violations. Make sure you have the JS Standard linter from the last lesson turned on in Atom. (If something is going wrong and you need some help, just let me know. 🙂)
• I think that for the rawP, htmlP, and string variables, we can come up with some better names. It's much better for a variable name to be too long than too short. 😎
• I most like how you're formatting the string concatenation (80% of the way there), but for optimal readability I would start the first level of the string on the next line, at the same level of indentation, then move the closing </p> tag to more closely match how you'd format normal HTML. I have an example below:

var string = 
  '<h1>Hi, my name is ' + firstName + ' ' + lastName + '!</h1>' +
  '<p>' + description + '</p>' +
  '<p>If you\'re interested in a date, you can email me at ' +
    '<a href="mailto:' + email + '"target="_blank">' + email + '</a>' +
    ' or give me a call at ' +
    '<a href="tel:' + phone + '" target="_blank">' + phone + '</a>.' +
  '</p>'

Let me know if you have any questions. Keep up the great work! 😄

[amitch6097]

@chrisvfritz Thank you for the help! I did forget to have JS Standard Linter on, so I turned it on and fixed all the errors. I fixed the names of some of the variables as well as the string formatting. Thank you for looking at my post! Let me know if there is anything more I need to do.

[chrisvfritz]

🔥 🎈 Beautiful! 🎈 🔥

:shipit: