search

amitdev / PMD-Intellij

Plugin for doing static analysis in Intellij using PMD
http://plugins.intellij.net/plugin/?id=1137
MIT License
67 stars 21 forks source link

Ability to select PMD version #63

Open sebastianhaberey opened 5 years ago

sebastianhaberey commented 5 years ago

Hi! First off, thank you for PMD-IntelliJ, we are using it in production here and it works fine! If I had one wish, it would be to be able to choose the PMD version that PMD-Intellij uses for checking, like the CheckStyle-IDEA plugin does:

checkstyle-intellij

The problem is that we like to keep our plugins up-to-date and when a new PMD-IntelliJ-Version comes out, everybody clicks "Update". But then, newly introduced PMD warnings pop up and we have a "no-warnings" check-in policy.

So now, someone has to review the newly introduced PMD rules and configure them according to team preferences. Also, the maven PMD configuration needs to be updated so the warnings on the build server match the warnings in IntelliJ. Sure, we're going to do this eventually, but we'd like to be able to do this as a planned item and not in the middle of a sprint.

There's an option in IntelliJ to configure the required plugin version for a project, but it doesn't seem to work as expected. I filed an issue for that, but I don't think it has top priority.

tl;dr updating PMD-IntelliJ often leads to new PMD warnings, creating unplanned work, user-stipulated PMD version would help

rbieniek commented 4 years ago

Another point here supporting the request is that the currently used PMD version is not handling recently introduced rules which came along with a newer version of PMD, for example 'AvoidMessageDigestField'

triestelaporte commented 4 years ago

I'd settle for a plugin that used PMD 6.22+ 😁 But specifying version would be nice.

amitdev commented 4 years ago

Updated to 6.25. Adding support to choose PMD version is tricky and I don't have time to look at it now. Happy to accept PRs though :)

jborgers commented 4 months ago

you can always download the desired release from GitHub and install the plugin in IntelliJ from file. Would that help?

sebastianhaberey commented 4 months ago

Wow this is ancient 😄 IIRC that doesn't help since IntelliJ would still offer to update the manually installed plugin every time a new PMD version comes out.