search

amitdev / lru-dict

A fast and memory efficient LRU cache for Python
MIT License
260 stars 46 forks source link

Add support to build & publish ARM & ppc64le wheels #41

Closed mgiessing closed 1 year ago

mgiessing commented 1 year ago

Signed-off-by: Marvin Giessing marvin.giessing@gmail.com

Thanks for this nice library @amitdev ! As this currently does not produce IBM Power wheels I've enabled cibuildwheel to support multi arch wheels (aarch64 & ppc64le) - this is not a change contentwise.

amitdev commented 1 year ago

Thanks. Looks good to me, but tbh I'm not familiar with cibuildwheel. Will wait to see if @AndreMiras has any comments before merging this.

mgiessing commented 1 year ago

just commited all the discussed changes, but it was indeed python3.6 who is the culprit here, since it doesn't seem to be available for ubuntu-22.04

0s
Run actions/setup-python@v4
Installed versions
  Version 3.6 was not found in the local cache
  Error: The version '3.6' with architecture 'x64' was not found for Ubuntu 22.04.
  The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

We could either remove it as you suggested or I revert that change to back to 20.04

AndreMiras commented 1 year ago

Thanks for the details! Yeah I would rather drop 3.6 than downgrading OS version, but let's see what Amit has in mind. In the meantime I've created a PR to drop both 2.7 and 3.6 and add 3.11. https://github.com/amitdev/lru-dict/pull/42

mgiessing commented 1 year ago

@amitdev what is your view on that? :-)