amitfin / patch

Home Assistant Integration for patching HA's files
MIT License
2 stars 1 forks source link

Make automatic HA restart optional #68

Closed tbclark3 closed 1 month ago

tbclark3 commented 1 month ago

Checklist

Is your feature request related to a problem? Please describe.

It is not always necessary, and not always desirable to restart Home Assistant after a patch is applied.

Describe the solution you'd like

Add a configuration parameter such as "Automatic Home Assistant Restart: True|False"

Describe alternatives you've considered

I uninstalled this integration when I figured out that there was no way to disable the automatic HA restart.

Additional context

This would be a very easy addition.

amitfin commented 1 month ago

Can you elaborate on the scenario? How do you know that a restart is not required? (I'm trying to understand the scenario so I can better document this new option and when it should be used.)

amitfin commented 1 month ago

v1.6.0 adds a new restart optional parameter. Default is true. When it's set to false, there is no HA restart after a patch.

I'm still curious to better understand the use case here.

tbclark3 commented 1 month ago

First, THANK YOU for your very prompt response! I use systemd to manage HA, and if systemd detects that HA has stopped, it will stop it, remove the container, and restart it. As long as systemd is the only thing restarting HA, it works smoothly and keeps good logs. Allowing Patch to restart would lead to a circle of restarts that would never end. In addition, restarting for me is not without issues thanks to several quasi-stable integrations. Iwatch the logs during a restart to see if anything pops up that I need to fix and restart a second time. Finally, although I know this is to some degree a crapshoot, if Patch runs before the patched file is needed, then there is no need for a restart.

amitfin commented 1 month ago

Thanks for sharing the details! Sounds fair. Closing the issue.