amitmahida92 / ng4-loading-spinner

Angular 4 custom async loading spinner.
MIT License
69 stars 31 forks source link

fix error in inlining when file is missing #37

Closed ocjojo closed 6 years ago

ocjojo commented 6 years ago

I encountered an error where templateUrl: ... is contained in a comment. The file that is referenced is missing, since it is not actually used. But the inline-resources.js tries to inline it anyway. With this I created a quick fix, that just returns the original templateUrl string instead of inlining it. A better approach would probably be to check if it is enclosed in a comment block.

Just so there is no confusion the comment block I am talking about is not my code, but in an angular core file.