search

amitmahida92 / ng4-loading-spinner

Angular 4 custom async loading spinner.
MIT License
69 stars 31 forks source link

Need this spinner support Angular 7 #51

Open wd4444 opened 5 years ago

wd4444 commented 5 years ago

Please help this library support Angular up to date

Muhanady commented 5 years ago

Actually it does support Angular 7, am using it with 7

wd4444 commented 5 years ago

How does it work with Angular 7? I am using Angular ver. 7.1.1. It shows error when run npm install: "npm WARN ng4-loading-spinner@1.2.3 requires a peer of @angular/core@^6.0.0 but none is installed. You must install peer dependencies yourself."

MrNuTruT commented 5 years ago

this is not a problem ! this is work on angular 7.X

twindual commented 5 years ago

Had the same problem with installing the peer dependencies. Here is one wasy to solve it:

-Open the "node_modules/ng4-loading-spinner/package.json" file -Update the following section in the "peerDependencies": { ... } section -Change: -FROM: "@angular/core": "^6.0.0", -TO: "@angular/core": "^6.0.0 || ^7.0.0", -Save the file

This will let it work with Angular 7 libraries in your project.