Add dark mode (w/ nicer toggle)

amitmerchant1990 / reverie

:art: A ridiculously elegant Jekyll theme.

https://reverie.pages.dev

MIT License

779 stars 683 forks source link

Add dark mode (w/ nicer toggle) #44

Closed ongyx closed 2 years ago

ongyx commented 3 years ago

Polished enough?

dartraiden commented 3 years ago

Does not work in Firefox (tested on Firefox 85 under Windows 10)

ongyx commented 3 years ago

I've added a workaround for Firefox: Screenshot (8)

Tested on version 85.0.1, Debian 10

amitmerchant1990 commented 3 years ago

@ongyx Would you be able to move the toggle right next to the "About" link in the navigation menu? Also, remove the text "toggle dark mode" and find a way that can self-describe the toggle's functionality just by looking at it without needing the text.

Something like https://codepen.io/gabemiller/pen/wvoMGBE and https://notepad.js.org.

ongyx commented 3 years ago

Okay, I moved the toggle beside the navbar and added a moon icon to show dark mode: record

amitmerchant1990 commented 3 years ago

I pulled your branch into my local and there is something still missing in the toggle it seems.

Also, please use the local instance of font-awesome.min.css by saving it into the assets/ folder.

ongyx commented 3 years ago

Actually, font-awesome was not needed for the toggle, so I'll remove it.

@amitmerchant1990 What browser are you using? I tested the toggle on both Chrome (88.0.4324.150, Windows 10) and Firefox (85.0.1, Debian 10).

amitmerchant1990 commented 3 years ago

I've tested it on Chrome 87 on Ubuntu 18.04.