Good time to apply this.

amitmerchant1990 / reverie

:art: A ridiculously elegant Jekyll theme.

https://reverie.pages.dev

MIT License

774 stars 676 forks source link

Good time to apply this. #85

Open manaspz opened 11 months ago

manaspz commented 11 months ago

          Thanks for the PR @Kolossi.

I would just suggest you move the logic to _includes/analytics.html file instead of creating a separate file. As I think, all the analytics code should live in a single file so it becomes more maintainable.

Thanks!

Originally posted by @amitmerchant1990 in https://github.com/amitmerchant1990/reverie/issues/48#issuecomment-777994156

manaspz commented 11 months ago

Now that Google has dropped support for UA. There is little to no requirement for the older analytics to exist.

Will generate a new PR for this soon.

manaspz commented 11 months ago

Successfully implemented the same on: https://github.com/amitmerchant1990/reverie/pull/86#issue-1835045246

List of changes:

Removed older UA tag in config.yml
Added support documentation in project readme
Removed additional analytics_head.html and migrated GA4 support to analytics.html

manaspz commented 11 months ago

@amitmerchant1990 Should I raise a PR ? That will include the following changes :

Changing the config tag to GA4 (This would affect your analytics page, please check if your GA4 is valid)
Modifying the old analytics file to favor the new tag : analytics.html
Removing redundant code for the analytics_head