search

amitmodak89 / magento-w2p

Automatically exported from code.google.com/p/magento-w2p
0 stars 0 forks source link

Move themes from default to base package #484

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Move our themes (zptheme, zp2steptheme and zpadvancedtheme) from default to 
base package for proper theme inheritance.

Original issue reported on code.google.com by Anatoly....@gmail.com on 17 Mar 2011 at 9:59

GoogleCodeExporter commented 8 years ago 
We need to explain this in HELP and give tips on what to do and what not to do 
when installing a custom theme.

Original comment by zetapri...@gmail.com on 17 Mar 2011 at 10:33

GoogleCodeExporter commented 8 years ago 
Is there a problem with inheritance from default package?
It is working so far.

Original comment by jamb...@gmail.com on 22 Mar 2011 at 11:31

GoogleCodeExporter commented 8 years ago 
We figured placing it into base gives more flexibility where the theme files go.
Some admins put them in places we wouldn't put them. The themes worked, w2p 
didn't.

Original comment by zetapri...@gmail.com on 22 Mar 2011 at 11:44

GoogleCodeExporter commented 8 years ago 
> Is there a problem with inheritance from default package?
> It is working so far.

Yep! When they don't put custom theme to default package.

Original comment by Anatoly....@gmail.com on 22 Mar 2011 at 5:00

GoogleCodeExporter commented 8 years ago 
Diff: http://code.google.com/p/magento-w2p/source/detail?r=1502

Original comment by Anatoly....@gmail.com on 31 Mar 2011 at 1:31

GoogleCodeExporter commented 8 years ago 
CustomThemeNative was updated a bit.

Diff: 
http://code.google.com/p/magento-w2p/source/diff?spec=svn1503&r=1503&format=side
&path=/wiki/CustomThemeNative.wiki

Original comment by Anatoly....@gmail.com on 31 Mar 2011 at 1:40

GoogleCodeExporter commented 8 years ago 
We need good explanations on what admins may need to do after installing this 
update.
It needs to be clear and detailed enough for us to include in HELP and write a 
blog post about it. 
Put them in release notes?

Update the wiki to say that any custom changes they make will be lost with an 
upgrade of w2p.

Original comment by zetapri...@gmail.com on 2 Apr 2011 at 2:55

GoogleCodeExporter commented 8 years ago 
Please, use 1.8.4.0beta6 release for testing.

Read ReleaseNotes page after you update extension. Test that everything works 
OK and nothing is broken.

Also we need to test it with custom theme. How can we organize it? Don't use 
hellowired theme for testing, it's broken.

Wiki: 
http://code.google.com/p/magento-w2p/source/diff?spec=svn1508&r=1508&format=side
&path=/wiki/ReleaseNotes.wiki

Original comment by Anatoly....@gmail.com on 3 Apr 2011 at 6:11

GoogleCodeExporter commented 8 years ago 
I don't know how to test this. Preview generations and ordering process work 
fine for me on /mageimage/
web_to_print_store_incl_theme   1.8.4.0beta6 (beta)

I still see the zptheme folder in
/mageimage/skin/frontend/default...
not
/mageimage/skin/frontend/base...

Do I need to 
1. install some custom theme on a instance that has an older version of the 
extension, 2. make changes to styles and layouts.xml, 
3. update the extension and make sure my changes are still there?

Original comment by agur...@gmail.com on 6 Apr 2011 at 4:53

GoogleCodeExporter commented 8 years ago 
Let's review the documentation and flag it as OK as long as everything else 
works.
We do need to make changes to our customization guide now.

Original comment by ad...@zetaprints.com on 7 Apr 2011 at 12:15

GoogleCodeExporter commented 8 years ago 
> I still see the zptheme folder in
> /mageimage/skin/frontend/default...
> not
> /mageimage/skin/frontend/base...

You see zptheme in skin/frontend/default/ directory because we have one image 
that is relative only to zptheme. And never used in custom themes.

And there won't be zptheme in skin/frontend/base

Original comment by Anatoly....@gmail.com on 7 Apr 2011 at 3:51

GoogleCodeExporter commented 8 years ago 
> Do I need to 
> 1. install some custom theme on a instance that has an older version of the
>    extension,
> 2. make changes to styles and layouts.xml, 
> 3. update the extension and make sure my changes are still there?

That will be a good testing example. But, please, don't forget to read release 
comments for 1.8.4.0 release at ReleaseNotes

Original comment by Anatoly....@gmail.com on 7 Apr 2011 at 6:03

GoogleCodeExporter commented 8 years ago 
Tested on d1 /mageimage/

1. Reinstalled /mageimage/
2. Installed web_to_print_store_incl_theme 1.8.4.0beta1 (beta) and setup 
products
3. Installed HelloWired
4. Added a custom "local.xml" file in 
/mageimage/app/design/frontend/default/hellowired/layout folder and removed 
PayPal logo, Cart sidebar, Recently viewed sidebars etc... through it
5. Edited styles.css file in /mageimage/skin/frontend/default/hellowired/css to 
some obvious color changes (link color, body bg color)
6. Confirmed that my changes were visible in the front end
7. Updated ext to web_to_print_store_incl_theme 1.9.0.0rc3 (beta) 
8. My changes (from 4. and 5.) are still there.

Left 
http://d1.zetaprints.com/mageimage/index.php/
like this in case you need to check other stuff and files. Will reinstall it 
before testing other issues in ~10hrs.

Original comment by agur...@gmail.com on 4 May 2011 at 9:01

GoogleCodeExporter commented 8 years ago 
D1 says it's RC2
What version are we testing?

Original comment by ad...@zetaprints.com on 4 May 2011 at 9:20

GoogleCodeExporter commented 8 years ago 
RC3 was installed on d1. I forgot to change version string before packaging it.

Original comment by Anatoly....@gmail.com on 5 May 2011 at 10:21

GoogleCodeExporter commented 8 years ago

Original comment by ad...@zetaprints.com on 5 May 2011 at 10:22

GoogleCodeExporter commented 8 years ago 
yep, the footer version was not up to date, the version number in M connect 
manager was rc3

Original comment by agur...@gmail.com on 5 May 2011 at 10:24

GoogleCodeExporter commented 8 years ago 
Updated
http://www.zetaprints.com/magentohelp/custom-theme-integration/
according to:
http://code.google.com/p/magento-w2p/source/diff?spec=svn1503&r=1503&format=side
&path=/wiki/CustomThemeNative.wiki

Original comment by agur...@gmail.com on 11 May 2011 at 9:05

GoogleCodeExporter commented 8 years ago 
Anatoly, please, review.

Original comment by ad...@zetaprints.com on 12 May 2011 at 4:14

GoogleCodeExporter commented 8 years ago

Original comment by ad...@zetaprints.com on 12 Jul 2011 at 11:52