Closed aksomers closed 3 years ago
There was some unexpected behavior in the dplyr join. It joined NA with NA for FIPS. I don't think the results of that join are valid. I'll message you in chat regarding how we'll handle this case.
Sounds good.
Just to document: most of the NA FIPS I saw didn't have any associated county string either, so there is no good place to attach that data. The solution I committed for now is to add the argument na_matches='never'
to the joins. We will just have to be careful not to over-generalize our results since we are missing some smaller counties.
These notes are in the code (haven't pushed yet).
Other missing NAs are related to FIPs. It looks like Mass combined two counties which is causing problems (Dukes and Nantucket) and some other missing FIPS are related to correctional facilities. Kansas City, MO is a problem. Bear River, UT is a problem. I think we can fix these one offs later, just good to note?
Since you joined on FIPS, these missing FIPs have got to be causing some join problems somewhere, right? Unless there's only one missing per state? Probably something else to check.