search

amitree / delayed_job_recurring

Extends delayed_job to support recurring jobs
MIT License
84 stars 33 forks source link

Remove and ignore Gemfile.lock #1

Closed iamvery closed 9 years ago

iamvery commented 9 years ago

I recently ran into some parallel computing issues with the clockwork gem. After some research we decided to use your gem to solve our problems by leaning on delayed jobs (which we already have in the app).

I came upon a few things that I thought would be worth adjusting in the gem. I hope you don't mind! Of course, I'm happy to hear your feedback and make any changes necessary to meet your liking :+1:

Generally the Gemfile.lock should not be included with library code. This allows each developer to carry their own set of locked dependencies and helps ensure that the dependencies of the library are defined in a flexible way.

For more information http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile

What do you think? :blush:

afn commented 9 years ago

Awesome — thanks for the contributions!

iamvery commented 9 years ago

You got it! Thanks for making something useful :relaxed: