search

amitree / delayed_job_recurring

Extends delayed_job to support recurring jobs
MIT License
84 stars 33 forks source link

Delayed job 3.x CI #5

Closed iamvery closed 9 years ago

iamvery commented 9 years ago

:warning: This will need to be rebased once #3 and #4 get merged, but I wanted to get it out there for discussion sooner than later.

This changeset is a little larger than I would have liked:

  1. Loosen version dependency for delayed job
  2. Add travis config to integrate with delayed job 3.x and 4.x
  3. Update test setup to be compatible with AR 3.x and 4.x

I'm not a huge fan of how big this diff is. I spent a little time trying to determine how to load the schema in a 3.x app. Rather than checking versions and going down that rabbit hole, I opted to remove the "skeleton" Rails app and only create the needed table. The required me to move around some requires as well...

What do you think? :eyes:

iamvery commented 9 years ago

rebased :+1:

afn commented 9 years ago

@iamvery Thanks again for all the help!

Are there any other outstanding issues? If not, I'll bump the version number and push this to rubygems.

Thanks! Tony

iamvery commented 9 years ago

@afn I don't think so! I've integrated against my fork. Thanks for getting to these so quickly. Looking forward to the release :dancer:

afn commented 9 years ago

Done. http://rubygems.org/gems/delayed_job_recurring

iamvery commented 9 years ago

:tada: