search

amitsaha / gitbackup

Tool to backup your Bitbucket, GitHub and GitLab repositories
MIT License
194 stars 33 forks source link

Fix Bug ignore private repo logic #80

Closed arborknot-ci closed 2 years ago

arborknot-ci commented 2 years ago

In line 48 if expression had a bug: private repos would be skipped if ignorePrivate is false.

amitsaha commented 2 years ago

@arborknot-ci thanks for the fix! Would you be able to add a test please? I have been trying to improve the code quality, and if we take these chances to at least add tests to start with, that would be progress.

shovalg commented 2 years ago

@amitsaha Hi, I'm sorry but I didn't quite understand the logic behind the tests you wrote nor I have the time to write one right now. If you could insert the PR for now, It would be much appreciated.

amitsaha commented 2 years ago

No worries, thanks - the new release has been created, binaries should be available shortly at https://github.com/amitsaha/gitbackup/releases/tag/v0.8.2