search

amitshekhariitbhu / RxJava2-Android-Samples

RxJava 2 Android Examples - How to use RxJava 2 in Android
https://outcomeschool.com
Apache License 2.0
4.96k stars 1.06k forks source link

The content on courses does not match the code #33

Open MilkBiscuit opened 6 years ago

MilkBiscuit commented 6 years ago

In Using Disposable in RxJava

disposables.clear() is invoked in onStop()

But in the comment and also Github disposables.clear() is invoked in onDestroy()

BTW, there are several typos on the page Using Disposable in RxJava:

Let's say there is an observable which emits some values, but while emitting values, the user presses back button, then it must stop emitting values.

amitshekhariitbhu commented 6 years ago

We will modify these soon.