Open flyingsymbols opened 4 years ago
Because of the "shell": True argument below, passing in a list will not work as expected, which I had to find out the hard way
"shell": True
@property def _default_popen_kwargs(self): return { "env": os.environ.copy(), "stdin": subprocess.PIPE, "stdout": subprocess.PIPE, "stderr": subprocess.PIPE, "shell": True, "universal_newlines": True, "bufsize": 0, }
This is true. I tried running
delegator.run(['make', 'clean'])
and got a very different result than what I was expecting! The current setup requires running:
delegator.run(['make clean'])
Because of the
"shell": True
argument below, passing in a list will not work as expected, which I had to find out the hard way