amitu / importd

django based mini framework inspired from sinatra. fully compatible with django.
http://amitu.com/importd/
BSD 3-Clause "New" or "Revised" License
511 stars 30 forks source link

Add whitenoise to support Heroku. #68

Closed if1live closed 9 years ago

if1live commented 9 years ago

Overview

If whitenoise is added to importd, it can run on heroku. https://importd-boilerplate.herokuapp.com/

https://devcenter.heroku.com/articles/django-assets

By default, Django does not support serving static files in production. We recommend using the WhiteNoise project for best-practice serving of static assets in production.

why not STATICFILES_STORAGE ?

If set STATICFILES_STORAGE, whitenoise support gzip. But It cause a problem. Cannot run unit test without collectstatic. So, I didn't add STATICFILES_STORAGE to importd. I think that appling whitenoise gzip or not is user's choice.

landscape-bot commented 9 years ago

Code Health Code quality remained the same when pulling 806e0dd on if1live:feature/heroku-support into 3b99493 on amitu:master.