search

amitu / importd

django based mini framework inspired from sinatra. fully compatible with django.
http://amitu.com/importd/
BSD 3-Clause "New" or "Revised" License
510 stars 30 forks source link

fixed #77 #78

Closed hitul007 closed 9 years ago

hitul007 commented 9 years ago
ghost commented 9 years ago

:-1: 

Python 2.7.6 (default, Jun 22 2015, 17:58:13)
[GCC 4.8.2] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from path import path
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: No module named path
>>>
Python 3.4.3 (default, Jul 28 2015, 18:20:59)
[GCC 4.8.4] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from path import path
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: No module named 'path'
>>>
hitul007 commented 9 years ago

@juancarlospaco Added dependency to setup.py. Now it'll work.

amitu commented 9 years ago

@hitul007, please add some test.

ghost commented 9 years ago

Why do we need path.py :grey_question: I never run into a case I can not handle with os.path Is mandatory to add path.py :grey_question: even more considering the new pathlib in standard lib now...

amitu commented 9 years ago

I think pathlib is better, thanks :-). pathlib itself is inspired from path.py, which has been part of all my python projects since 12+ years.

This will break some code, but I think we should take the hit now, and fix all those code.

ghost commented 9 years ago

If you gonna add it as mandatory dependency and is better why not use pathlib instead :grey_question: Its for python2 also according to itself and pypi, and you dont need anything for python3...

landscape-bot commented 9 years ago

Code Health Code quality remained the same when pulling 4305214 on hitul007:master into c76d259 on amitu:master.

landscape-bot commented 9 years ago

Code Health Code quality remained the same when pulling ede75bc on hitul007:master into c76d259 on amitu:master.

hitul007 commented 9 years ago

@juancarlospaco Thanks for suggesting pathlib. I tried it but it is not working in Logger. It don't have startswith method. Logger is raising an exception. So, I think we should continue with pathpy. I tried this in python 2.7.

amitu commented 9 years ago

Damn, 0.5.0 :-). I would have made it 0.4.1 :-)

hitul007 commented 9 years ago

@amitu Okay. Let me change it.

ghost commented 9 years ago

SemVer explains when you should change one or another number...

hitul007 commented 9 years ago

@amitu Sent a PR with 0.4.1.