search

amiv-eth / amivapi

The REST API behind most of AMIV's web services.
http://api.amiv.ethz.ch/docs
GNU Affero General Public License v3.0
30 stars 6 forks source link

Login with email address #598

Closed niccantieni closed 9 months ago

niccantieni commented 11 months ago

Truncate any emailadress that matches *@*ethz.ch to everything before the @.

NotSpecial commented 11 months ago

Hi, and thanks for your contribution.

Can you please provide some examples where this functionality is needed? Is there any concrete case that is failing with the current login scheme?

If we have some examples, they could be included in the test cases to ensure the problem is fixed.

niccantieni commented 11 months ago

Hi @NotSpecial! I discussed it with @temparus, it'a just that today's Erstis are trying to sign in with their emailadress, but that doesn't work, as our logic only uses ETH-LDAP if a ETH-username is used (I think?)

NotSpecial commented 11 months ago

Do I get it right that the issue is that ersties try to log in with their email address, not their username?

I guess we could try both at the API level. I'd give this a rather low priority though, as it's pretty easy for people to figure out, I guess ^^

If you need any advice on how to implement it, let me know.

temparus commented 11 months ago

With the new ETH login system, users often have to use @ethz.ch as their username. In combination with the username label "nethz or email" then mislead them to use the credentials they had to use for other ETH services which includes the @ethz.ch postfix.

It definitely has low priority but would be a nice enhancement to have.