amiv-eth / amivapi

The REST API behind most of AMIV's web services.
http://api.amiv.ethz.ch/docs
GNU Affero General Public License v3.0
30 stars 6 forks source link

pagination is broken #600

Open suisseWalter opened 11 months ago

suisseWalter commented 11 months ago

There is currently a problem, in the admin-tool, that certain events/groups appear twice or more, while others don't appear at all. This is because the answer to the get (list) requests contains some elements twice(same uuid). each element appears at most once per request. For the groups page this is a massive problem, as some groups are there 3-5, while some(only a few) groups don't show up at all.

use the following request, with page 1---6. and then some groups, such as HOPO- MAVT be there twice, and some will be missing(such as HOPO-ITET vorstand). If I just increase the pagesize("max-results") to contain all groups in one request it's fine. don't forget to add your auth-token to be able to properly execute this. it works the same with events. (but as events frequently change, it's not reliable)

curl 'https://api.amiv.ethz.ch/groups?sort=null&max_results=10&page=1' --compressed -H 'User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/118.0' -H 'Accept: application/json, text/plain, */*' -H 'Accept-Language: en-US,en;q=0.5' -H 'Accept-Encoding: gzip, deflate, br' -H 'Referer: https://admin.amiv.ethz.ch/' -H 'Authorization: **YOUR-TOKEN**' -H 'Origin: https://admin.amiv.ethz.ch' -H 'DNT: 1' -H 'Connection: keep-alive' -H 'Sec-Fetch-Dest: empty' -H 'Sec-Fetch-Mode: cors' -H 'Sec-Fetch-Site: same-site' -H 'If-Modified-Since: Thu, 28 Sep 2023 13:02:50 GMT'