search

amiv-eth / amivapi

The REST API behind most of AMIV's web services.
http://api.amiv.ethz.ch/docs
GNU Affero General Public License v3.0
30 stars 6 forks source link

Include ICS Calendar Invites to Event Signup Acceptance Emails #604

Closed kunerj closed 10 months ago

kunerj commented 10 months ago

It would be nice to have calendar invites for events to lower the amount of spontaneous de-registrations because of people forgetting about events.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b6cbd1c) 94.66% compared to head (9e2851b) 94.73%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #604 +/- ## ========================================== + Coverage 94.66% 94.73% +0.07% ========================================== Files 75 75 Lines 4272 4311 +39 ========================================== + Hits 4044 4084 +40 + Misses 228 227 -1 ``` | [Flag](https://app.codecov.io/gh/amiv-eth/amivapi/pull/604/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=amiv-eth) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/amiv-eth/amivapi/pull/604/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=amiv-eth) | `94.73% <100.00%> (+0.07%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=amiv-eth#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/amiv-eth/amivapi/pull/604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=amiv-eth) | Coverage Δ | | |---|---|---| | [amivapi/events/emails.py](https://app.codecov.io/gh/amiv-eth/amivapi/pull/604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=amiv-eth#diff-YW1pdmFwaS9ldmVudHMvZW1haWxzLnB5) | `97.40% <100.00%> (+0.43%)` | :arrow_up: | | [amivapi/tests/events/test\_emails.py](https://app.codecov.io/gh/amiv-eth/amivapi/pull/604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=amiv-eth#diff-YW1pdmFwaS90ZXN0cy9ldmVudHMvdGVzdF9lbWFpbHMucHk=) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/amiv-eth/amivapi/pull/604/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=amiv-eth)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kunerj commented 10 months ago

Thanks for your valuable comments! I implemented your suggested changes.