search

amiv-eth / amivapi

The REST API behind most of AMIV's web services.
http://api.amiv.ethz.ch/docs
GNU Affero General Public License v3.0
30 stars 6 forks source link

Issue 493: Fix missing email notifications on manual waitlist updates #605

Closed kunerj closed 10 months ago

kunerj commented 10 months ago

Tackling issue #493 of missing notifications if eventsignups items are updated via PATCH requests. The corresponding hook was missing.

codecov[bot] commented 10 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (a5c1147) 94.65% compared to head (d939643) 94.68%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #605 +/- ## ========================================== + Coverage 94.65% 94.68% +0.03% ========================================== Files 75 75 Lines 4247 4272 +25 ========================================== + Hits 4020 4045 +25 Misses 227 227 ``` | [Flag](https://app.codecov.io/gh/amiv-eth/amivapi/pull/605/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=amiv-eth) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/amiv-eth/amivapi/pull/605/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=amiv-eth) | `94.68% <100.00%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=amiv-eth#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/amiv-eth/amivapi/pull/605?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=amiv-eth) | Coverage Δ | | |---|---|---| | [amivapi/events/queue.py](https://app.codecov.io/gh/amiv-eth/amivapi/pull/605?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=amiv-eth#diff-YW1pdmFwaS9ldmVudHMvcXVldWUucHk=) | `100.00% <100.00%> (ø)` | | | [amivapi/tests/events/test\_emails.py](https://app.codecov.io/gh/amiv-eth/amivapi/pull/605?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=amiv-eth#diff-YW1pdmFwaS90ZXN0cy9ldmVudHMvdGVzdF9lbWFpbHMucHk=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.