search

amiv-eth / amivapi

The REST API behind most of AMIV's web services.
http://api.amiv.ethz.ch/docs
GNU Affero General Public License v3.0
30 stars 6 forks source link

Rewrite Waiting List Email #624

Open alexander-schoch-linuxdays opened 9 months ago

alexander-schoch-linuxdays commented 9 months ago

There's two cases why a user would receive the "events_waitignList" email:

  1. The event is full. In this case, they end up on the waiting list and can be accepted if people sign off.
  2. The event moderator has to approve of the participants, and thus all users end up on the waiting list.

The current text reads as follows:

Hello {{ name }}!

We are sorry to inform you that your signup for {{ event }} was rejected because there are no free spots available.

We put you on a waiting list and we will send you an email when a spot becomes available.

Best Regards,
AMIV

This text is well-suited for case 1, but very confusing for case 2. I got confused twice within one month about this now, so I'm creating a PR.

suisseWalter commented 9 months ago

looks good. This has been a criticism for a long time. and this is a nice solution that doesn't require change any logic, the suggestion was always that there should be two different emails.

temparus commented 8 months ago

As we check for specific phrases in our unit tests, you should update the test cases in amivapi.tests.events.test_emails.py.