search

amix / vim-zenroom2

A Vim extension that emulates iA Writer environment when editing Markdown, reStructuredText or text files
254 stars 21 forks source link

Renamed functions to start with an uppercase character #6

Closed beefsack closed 9 years ago

beefsack commented 10 years ago

This should fix #5.

shuhei commented 10 years ago

:+1:

ZenroomGoyoBefore and ZenroomGoyoAfter look more natural to me, though.

shuhei commented 10 years ago

Ah, goyo's README suggests scoping with s:.

beefsack commented 10 years ago

Yeah I think s: is a better idea, changing now.

beefsack commented 10 years ago

I've now changed the function to be prefixed by s: instead of g: which removes the start up errors.

shuhei commented 10 years ago

Thanks :-)

beefsack commented 10 years ago

@amix, sorry to be a pain, but any chance this PR could be looked at? This issue is causing errors on startup which I'd love to be resolved.

drn commented 10 years ago

+1

ev0rtex commented 10 years ago

+1 Just manually changed this in mine until a fix is released

victorandree commented 10 years ago

:+1: for me as well, for what it's worth.

lyager commented 10 years ago

+1 for me to. 's:' is better, as it doesn't polute the public namespace (as it also would with my fix which used g:Zenroom_goyo_before).

matthieuauger commented 9 years ago

:+1: