Fix unexpectly saved config entry: added_config - Githubissues

amjltc295 / pytorch-golden-template

PyTorch Golden Template (under development)

13 stars 4 forks source link

Fix unexpectly saved config entry: added_config #63

Closed Nash2325138 closed 5 years ago

Nash2325138 commented 5 years ago

Why do we need this PR?

SingleGlobalConfig.added_config will be treated as an entry to save in config.json, which overwrite the correct added_config when resuming from the checkpoint, causing key not found error in SingleGlobalConfig.print_changed

How is it implemented?

Change added_config to _added_config

PR readiness checklist

[x] Did it pass the Flake8 check?

[x] Did you test this PR?