search

amkirwan / ember-oauth2

JavaScript library for using OAuth 2.0 Implicit Grant flow (Client-Side Flow) with Ember.js
MIT License
133 stars 22 forks source link

.amd.js not included in bower release #13

Closed dslamba closed 9 years ago

dslamba commented 10 years ago

The Bower release package does not include the AMD version of the lib file

amkirwan commented 9 years ago

Are you using Ember-ClI? You should be able to include it in your Brocfile.js doing the following.

app.import('vendor/ember-oauth2/lib/ember-oauth2.js')

This will import the ES6 file and Broccoli will handle transcoding it.

Any file you are using the EmberOauth2 in just include

import OAuth2 from 'vendor/ember-oauth2/lib/ember-oauth2';

In future releases I will probably include a dist directory in github so that Bower release will include all of the builds.

mattmarcum commented 9 years ago

doing an app.import('vendor/ember-oauth2/lib/ember-oauth2.js') does not work for me on ember-cli#0.0.44

The file does not get transcoded so I get errors in the console about reserved words

amkirwan commented 9 years ago

There have been some changes between EmberCli 0.4.0 and EmberCli 0.4.1+ addons and bower_components are compiled. This is probably what the issue is since EmberOAuth2 is currently build against 0.4.0. I'll try to fix the problem in the next day or two.

amkirwan commented 9 years ago

Added dist directory to Release v0.5.2 Updated to work with Ember 1.7 moved dependency to bower_components from vendor dir