amkirwan / ember-oauth2

JavaScript library for using OAuth 2.0 Implicit Grant flow (Client-Side Flow) with Ember.js
MIT License
133 stars 22 forks source link

Remove bower dependencies. #21

Closed rwjblue closed 8 years ago

rwjblue commented 8 years ago

When using this library via bower, these dependencies are not actually useful/required. A consuming application will already need to include some of these, but they are not directly required by ember-oauth2 as far as I can tell.

Please feel free to close this if I have misunderstood things here...

amkirwan commented 8 years ago

I agree those probably should be in the devDependencies. The only one I'm thinking about leaving in dependencies array is Ember. I would assume a consuming application would require it but I do use Ember.Object directly in the code. What do you think?