amkirwan / ember-oauth2

JavaScript library for using OAuth 2.0 Implicit Grant flow (Client-Side Flow) with Ember.js
MIT License
133 stars 22 forks source link

Fix typo in ember-oauth2.js #28

Closed mphasize closed 7 years ago

mphasize commented 7 years ago

If a "scope" is defined, Ember would fail with Assertion Failed: Cannot callEmber.getwith an empty string, due to the get('.scope') call. This should fix it.

alexgaribay commented 7 years ago

I'm running into this issue. Can this get merged?

amkirwan commented 7 years ago

looks good thanks

miguelcobain commented 7 years ago

Can we get this released, please? This fix isn't published on npm.

amkirwan commented 7 years ago

@miguelcobain whoops :( I'll release it to npm tonight