search

amkozlov / raxml-ng

RAxML Next Generation: faster, easier-to-use and more flexible
GNU Affero General Public License v3.0
379 stars 64 forks source link

include terraphast and libpll in source code distribution #61

Closed joelb123 closed 3 years ago

joelb123 commented 5 years ago

I realize that the instructions say to do a recursive git pull, but if you are going to provide a source package with each release, it should really have the dependent libraries in it.

amkozlov commented 5 years ago

Those source packages are created automatically by GitHub, and unfortunately there is no way I can add submodules to them. In fact, i cannot even remove those packages! This is one of those weird cases, when everybody knows it's broken, for many years, but apparently github developers do not care:

https://stackoverflow.com/questions/32909389/how-to-creating-github-release-that-includes-submodule

I could add a custom download with full archive (incl. submodules) if you think it would be helpful. However, I'm afraid that having two source packages attached to each release would be even more confusing.

So I can just recommend using git clone --recursive, which seems to be the only bulletproof solution atm. As a bonus, you'll get the most recent version with the latest bugfxes :)

amkozlov commented 3 years ago

Starting with v1.0.0, full source package including submodules will be provided. Unfortunately, I still have to create them manually and still cannot delete the default incomplete packages. Shame on GitHub :bell: :bell: :bell: