search

amkozlov / sativa

Semi-Automatic Taxonomy Improvement and Validation Algorithm
GNU General Public License v3.0
16 stars 7 forks source link

Python 3 support #2

Closed dgslos closed 1 year ago

dgslos commented 3 years ago

Since Python 2 is end of life, it would be great to see Python 3 support for SATIVA.

amkozlov commented 3 years ago

@dgslos I just moved SATIVA to Python 3, please feel free to test!

dgslos commented 3 years ago

@amkozlov, I can confirm sativa is running with Python 3. I just tested it inside a docker. Thanks for moving it to Python 3!

amkozlov commented 3 years ago

@dgslos perfect, thanks for confirmation!

dgslos commented 3 years ago

I was a bit too fast image

amkozlov commented 3 years ago

please try to replace this line

https://github.com/amkozlov/sativa/blob/master/sativa.py#L366

with

 rank_parent, rank_tips = self.get_parent_tip_ranks(self.tax_tree)
dgslos commented 3 years ago

I did that. Now it can't find an attribute image

I don't see a method defined with that name in the class. My python is not could enough to understand classes fully.

amkozlov commented 3 years ago

Sorry, apparently you are using -ranktest option which I haven't tested after Python 3 conversion. It should be fixed now, please check.

amkozlov commented 1 year ago

I assume this is now fixed. Otherwise, please reopen.