RAML1.0 -> OAS3.0: Traits are not resolved

[Kaiser1989]

• I'm submitting a ...

  • [x] bug report
  • [ ] feature request
  • [ ] question
  • [ ] other

• What is the current behavior?

Raml Traits are not resolved, leading to "x-amf-is" and "x-amf-traits".

Converting this simple RAML file:

#%RAML 1.0

title: Trait example
version: v1
baseUri: http://localhost:8080

traits:
  X400:
    responses:
      400:
        description: Bad Request
        body:
          application/json:
            type: string

/meta:
  description: Meta information about this service
  get:
    description: Get app information
    is:
    - X400
    responses:
      200:
        description: OK
        body:
          application/json:
            type: string

• If the current behavior is a bug, please provide the minimal steps to reproduce with AMF code. Please don't upload AMF code mixed with yours.

Java function to convert raml file to oas file:

public static void ramlToOasWithoutFix(final File raml, final File oas) throws Exception {
    AMF.init().get();
    BaseUnit model = new Raml10Parser().parseStringAsync(new String(Files.readAllBytes(raml.toPath()))).get();
    Files.write(oas.toPath(), new Oas30Renderer().generateString(model).get().getBytes());
}

Output is:

{
  "openapi": "3.0.0",
  "info": {
    "title": "Trait example",
    "version": "v1"
  },
  "servers": [
    {
      "url": "http://localhost:8080"
    }
  ],
  "paths": {
    "/meta": {
      "description": "Meta information about this service",
      "get": {
        "description": "Get app information",
        "x-amf-is": [
          "X400"
        ],
        "responses": {
          "200": {
            "description": "OK",
            "content": {
              "application/json": {
                "schema": {
                  "type": "string"
                }
              }
            }
          }
        }
      }
    }
  },
  "components": {
    "x-amf-traits": {
      "X400": {
        "responses": {
          "400": {
            "description": "Bad Request",
            "body": {
              "application/json": {
                "type": "string"
              }
            }
          }
        }
      }
    }
  }
}

• What is the expected behavior?

The output should be:

`{
  "openapi": "3.0.0",
  "info": {
    "title": "Trait example",
    "version": "v1"
  },
  "servers": [
    {
      "url": "http://localhost:8080"
    }
  ],
  "paths": {
    "/meta": {
      "description": "Meta information about this service",
      "get": {
        "description": "Get app information",
        "responses": {
          "200": {
            "description": "OK",
            "content": {
              "application/json": {
                "schema": {
                  "type": "string"
                }
              }
            }
          },
          "400": {
            "description": "Bad Request",
            "content": {
              "application/json":  {
                "schema": {
                  "type": "string"
                }
              }
            }
          }
        }
      }
    }
  }
}

• Please tell us about your environment:

  • AMF Version: 4.3.0
  • AMF Distribution: JVM
  • Operating System: Windows 10 64 bit

[tomsfernandez]

Duplicate of https://github.com/aml-org/amf/issues/646

[ShauniArima]

This issue does not seems to be a duplicate of #646. Resource types seems to be resolved but not traits.

Would you want a sample that expose this behaviour ?

[tomsfernandez]

HI @ShauniArima this issue is a duplicate because the cause (misuse of AMF to migrate between RAML 1.0 and OAS 3.0) is the same. That is why it is a duplicate.

[ShauniArima]

Hmmm I'll check that tomorrow but after resolving the model there is still a bad output. I'll create an example to explain this issue if you want.