amlan-roy / resume-craft

Resume Craft: Your go-to platform for effortlessly tailoring ATS-friendly resumes to job descriptions. Streamline your job application process and stand out in the competitive market.

https://resume-craft-ten.vercel.app

7 stars 3 forks source link

Footer Links Open New Tab #30

Closed avi-l closed 8 months ago

avi-l commented 8 months ago

https://github.com/amlan-roy/resume-craft/issues/29

Summary

Open Footer Links in New Tab

Requirement:

Changes made:

add target="_blank" to component in Footer

How Has This Been Tested?

Ran locally, tested links do pop open in new tab

https://github.com/amlan-roy/resume-craft/assets/68050609/bf05871f-a5ea-45de-90c0-7bcc0c9d832a

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
resume-craft	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 28, 2024 8:06am

avi-l commented 8 months ago

screen recording added to PR summary.

amlan-roy commented 8 months ago

Snapshots needs to be updated. Can merge the PR after the snapshots have been updated.

@avi-l : Running the command npm run test -- -u will update the jest snapshots. Once the snapshots are updated, the existing tests will pass. We can then merge this PR to master.

avi-l commented 8 months ago

ha, ok sorry, I misunderstood for what you were asking.. standby...

amlan-roy commented 8 months ago

ha, ok sorry, I misunderstood for what you were asking.. standby...

No worries. Thanks for the effort. Merging this PR 🚀