amlan-roy / resume-craft

Resume Craft: Your go-to platform for effortlessly tailoring ATS-friendly resumes to job descriptions. Streamline your job application process and stand out in the competitive market.
https://resume-craft-ten.vercel.app
7 stars 3 forks source link

Fixed the issue of validation being triggered on delete section button being clicked #4

Closed amlan-roy closed 8 months ago

amlan-roy commented 8 months ago

Summary

Requirement:

The form validation was triggered when delete section button was clicked. Fix it.

Changes made:

Just added the type="button" in the Professional Summary section's delete button. The issue was that since no type was set in the button, and in the DOM this button was being rendered inside a form, these buttons were also being considered as a submit button. So, the submit was being triggered when these delete button were clicked, and hence the validations were being triggered.

How Has This Been Tested?

Jabba JabbaShahidGIF

Checklist:

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
resume-craft ✅ Ready (Inspect) Visit Preview Jan 17, 2024 10:11pm