Closed amlan-roy closed 7 months ago
Hi @amlan-roy! New contributor here and I would be interested to work on this. Let me know if I can pick this up.
Hi @amlan-roy! New contributor here and I would be interested to work on this. Let me know if I can pick this up.
@tusharwebd: Sure. You can go ahead and assign the issue to yourself. Thanks.
I believe only repo owners can assign the issue. So feel free to assign this to me. I'll start working on issue in the meanwhile.
@tusharwebd : Updated the issue description a bit to be more clear about the requirements.
Thanks for the suggestions as well! I've made the required fix in this PR: https://github.com/amlan-roy/resume-craft/pull/52.
Merged the PR. Thanks for the efforts @tusharwebd!
Is your feature request related to a problem? Please describe.
Issues:
<Header>
and<Footer>
elements inside<main>
, but we want the structure to be<><Header /><main>{children}</main><Footer /></>
instead.Suggestions
Run the repo locally by running
npm run dev
src\app\layout.tsx
), should have the following structuresrc\app\layout.tsx
file, addmin-height: 100vh
,display: flex
andflex-direction: column
tailwind classesfixed bottom-0 left-0 right-0
from footer (in `src\components\global\Footer.tsx)Are you willing to contribute to this issue?
Yes, but help is always welcomed
Additional Details
Test all the routes to see if the UI is working as expected Routes to check: