Summary

This fixes issue #48

Requirement:

The footer is fixed at bottom of viewport and overlaps the other elements. We want them to be at the bottom of the whole page, not fixed to the bottom of the viewport.

Changes made:

Added tailwind classes to ensure main component takes 100% of viewport and used flex classes to convert component into flex containers.

How Has This Been Tested?

Screenshots / Videos

https://github.com/amlan-roy/resume-craft/assets/59330872/2606e3c9-5ab4-4e1e-b563-a87738ab071f

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
resume-craft	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 12, 2024 0:16am

tusharwebd commented 7 months ago

I see unit tests failed. Let me check on this.

tusharwebd commented 7 months ago

We would also need to add className="flex-grow" in all the layout.tsx files (except thesrc\app\layout.tsx file). Otherwise, the footer would not be pushed down if the height of the main content does not cover the full screen. You can refer the deployment of this branch to see this behaviour.

Makes sense. Checking on this.

tusharwebd commented 7 months ago

@amlan-roy, I've requested access for the vercel deployment.

amlan-roy / resume-craft

fix: update footer to not be fixed to bottom of viewport #52

Summary

Requirement:

Changes made:

How Has This Been Tested?

Screenshots / Videos

Checklist: