amlan-roy / resume-craft

Resume Craft: Your go-to platform for effortlessly tailoring ATS-friendly resumes to job descriptions. Streamline your job application process and stand out in the competitive market.
https://resume-craft-ten.vercel.app
7 stars 3 forks source link

Figure out alternative approach for the form components #9

Closed amlan-roy closed 8 months ago

amlan-roy commented 8 months ago

Describe the issue in detail The form components of shadcn library are controlled components using react-hook-forms, and are good when used directly inside the form.

But we want to create reusable components that are going to use these form components, so we want them to be uncontrolled.

This will also make unit/integration testing these components easier.

Describe the solution you'd like We can ditch shadcn's form and use our custom form. In this way, we can ensure that these components are uncontrolled. This can address the above issue.

Describe alternatives you've considered Another approach can be that we can modify the form components generated using shadcn to be uncontrolled. I have not investigated the feasibility of this solution yet.

Additional context Dont want to spend too much time on this as I want the MVP to be up and running ASAP.