search

amluto / virtme

An easy way to virtualize the running system
GNU General Public License v2.0
330 stars 66 forks source link

Support for dynamically-linked busybox #13

Open zevweiss opened 7 years ago

zevweiss commented 7 years ago

I understand if this is a bit "controversial" (i.e. not wanted); it's definitely a bit of a hack, but it does let virtme work in some situations where it currently doesn't.

amluto commented 6 years ago

There were some other fixes recently to help find a static busybox. Is this still needed?

zevweiss commented 6 years ago

"Needed" might be a bit strong; still potentially useful in some cases though. I'm not aware offhand of any distros that don't package a static build of busybox, though as seen in commit c39a1cd18f they may be under different names (e.g. on my current system it's /usr/bin/busybox.static -- note the . instead of -). We could just add another entry to the hard-coded list in find_busybox(), but trying to accommodate dynamically-linked builds might make it slightly more likely to "just work" on arbitrary/unknown other systems -- though as previously noted, the patch isn't entirely a thing of beauty, so if you'd prefer the former I wouldn't particularly mind.

zevweiss commented 5 years ago

Ping...any further thoughts on this?

jadahl commented 2 years ago

Just noticed this, after having implemented an equivalent variant of this but using pyelftools instead of parsing ldd: https://github.com/amluto/virtme/pull/77