search

amluto / virtme

An easy way to virtualize the running system
GNU General Public License v2.0
330 stars 66 forks source link

Assorted stuff: Documentation cleanup and module directory parameter #19

Closed ezequielgarcia closed 5 years ago

ezequielgarcia commented 6 years ago

Hey Andy,

virtme is the most useful kernel development tool I came across recently: so, thanks!

That said, here's a pull request. It contains a couple things. First, a new parameter to specify a module install path. Then, a small documentation improvement.

UPDATE: https://github.com/amluto/virtme/pull/9 is also trying to specify a modules directory. My version is simpler, but more limited as it won't install modules to a initramfs. The use case is of course using kimg/kdir and wanting to use modules.

ezequielgarcia commented 6 years ago

Sure, I can do that.

ezequielgarcia commented 6 years ago

@amluto v2 with an example in the README.md

marcosps commented 5 years ago

@amluto do you still want to merge this request? It's very useful, I'm using his patch for some time and it would be nice to merge this feature, along with others that @ezequielgarcia has in his private repository.

amluto commented 5 years ago

Are you finding this to be useful in cases where --installed-kernel doesn't do the trick? If so, what are you doing that makes this work but --installed-kernel not work?

What I really want is a way to mostly automatically pull modules from a kernel build tree without installing the kernel at all. Unfortunately, last time I played with this, I found the module tools to be too inflexible.

marcosps commented 5 years ago

@amluto I'm using this argument along with --kdir, usually testing a compiled kernel directory for kdir and and installed modules using --mdir.

Is there any other way to do the same using the already defined arguments?

marcosps commented 5 years ago

@amluto ping :)

amluto commented 5 years ago

I think that #38 should mostly supersede this. Can you take a look? I’m not averse to merging this, too, but I want to make sure this converges to something that will cover enough of the bases without too much cognitive load.

marcosps commented 5 years ago

I`m looking at the patches submitted in #38.

marcosps commented 5 years ago

38 was merged. @amluto do you think this can be closed?

amluto commented 5 years ago

38 was merged. @amluto do you think this can be closed?

Yes. @ezequielgarcia, please let me know if you think further changes are in order.