search

amluto / virtme

An easy way to virtualize the running system
GNU General Public License v2.0
330 stars 66 forks source link

Transform virtme/guest into a Python package #23

Closed gagallo7 closed 5 years ago

gagallo7 commented 6 years ago

Related issue: #21

setup.py doesn't copy the necessary bash files from virtme/guest folder to the installed folder. This will make virtme-run to fail when running with--kimg argument, for example.

This problem can be solved if we transform virtme/guest folder, which only have bash scripts, into a python package via adding a init.py file and instructing setup.py that virtme.guest is a package and we will need its contents as package data.

This idea was based on the setuptools docs advice: https://setuptools.readthedocs.io/en/latest/setuptools.html#non-package-data-files

This PR has the related contribution of @ezequielgarcia, which improved the requirements for setup.py script.

amluto commented 5 years ago

Merged, with some followup improvements. For future reference, please add Signed-off-by lines, though.