search

amluto / virtme

An easy way to virtualize the running system
GNU General Public License v2.0
330 stars 66 forks source link

virtme-prep-kdir-mods: Add --copy-modules argument #68

Closed vadorovsky closed 1 year ago

vadorovsky commented 3 years ago

Symbolic linking of kernel modules to .virtme_mods/... is problematic when running xfstests. Some of them are copying modules to SCRATCH disks without following links[0]. This change allows for optional copying of modules to avoid xfstests failures with the new --copy-modules argument.

[0] https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git/tree/tests/btrfs/012?id=37d4f926b525fbba8aa579b9eea4ae0921ea7b7b#n55

Signed-off-by: Michal Rostecki mrostecki@suse.de

marcosps commented 2 years ago

@vadorovsky makes sense. @amluto what do you think?

arighi commented 1 year ago

This has been merged in https://github.com/arighi/virtme

NOTE: we are trying to catch up with all the pending PR in this temporary fork. In the future we may merge everything back here if this project become active again, but for now please consider to follow also the development of arighi/virtme.

vadorovsky commented 1 year ago

@arighi Thanks! To be clear, would you prefer PRs to https://github.com/arighi/virtme or to https://github.com/arighi/virtme-ng next time?

arighi commented 1 year ago

On Mon, May 01, 2023 at 09:48:08AM -0700, vadorovsky wrote:

@arighi Thanks! To be clear, would you prefer PRs to https://github.com/arighi/virtme or to https://github.com/arighi/virtme-ng next time?

At this point I think it'd be easier to continue the development in virtme-ng. Later in the future if the original virtme is resumed we can easily merge everything back.

Thanks, -Andrea