search

amluto / virtme

An easy way to virtualize the running system
GNU General Public License v2.0
330 stars 66 forks source link

Some fixes for `--script-exec`/`--script-sh` #7

Closed zevweiss closed 7 years ago

zevweiss commented 8 years ago

These patches address issue #6 (for me, at least) and make a couple other minor fixes.

zevweiss commented 8 years ago

Hmm, though now I'm realizing 480988a will probably break non-intramfs situations...updated to make including the tmpfs mount conditional on !need_initramfs.

amluto commented 7 years ago

The last three changes look good. For the first two, could you respin them as:

  1. Add initargs but make no other changes (and change '; ' to ';' to avoid changing anything).
  2. Add the improved logic?

Also, could you rebase and add Signed-off-by to your commit messages?

zevweiss commented 7 years ago

OK, now updated accordingly (assuming I understood correctly -- if not let me know).

amluto commented 7 years ago

All done. Thanks!