search

amluto / virtme

An easy way to virtualize the running system
GNU General Public License v2.0
330 stars 66 forks source link

Stash stty_con before cleaning up env #79

Closed DylanZA closed 1 year ago

DylanZA commented 1 year ago

All virtme_* variables are cleaned up, but virtme_stty_con is used a bit further on. Stash it locally to not lose it.

I'm not terribly experienced with bash, so this might be the wrong way to do this but it seems to work for me

Signed-off-by: Dylan Yudaken dylany@meta.com

marcosps commented 1 year ago

@DylanZA I believe that you would like to propose the patch to virtme-ng: https://github.com/arighi/virtme-ng

@amluto is basically unreachable for a couple of months already, and virtme-ng is the fork that is being maintained and accepting patches, while keeping the same functionality of virtme.

DylanZA commented 1 year ago

hmm - I might try do that - but I havent tested it in ages so honestly its unlikely

if you want to port it across be my guest!