amluto / virtme

An easy way to virtualize the running system
GNU General Public License v2.0
330 stars 66 forks source link

`virtme-run --mods=auto` is not working with kernels >=6.2 #82

Open matttbe opened 1 year ago

matttbe commented 1 year ago

virtme-prep-kdir-mods: support kernel 6.2

Thank you for having created and maintained this very handy tool!

Since the kernel commit https://github.com/torvalds/linux/commit/f65a486821cf ("kbuild: change module.order to list *.o instead of *.ko") that is now in Linus tree in preparation of the future v6.2, module.order file lists .o files instead of .ko ones.

virtme-prep-kdir-mods reads module.order file but it needs to create symlinks for the .ko files, not the .o ones.

dbrouwer3563 commented 1 year ago

@matttbe thanks for this patch - I was having the same problem today so just tested your patch and it worked perfectly. Not sure if this is best practice, but I had to manually delete the .virtme_mods folder in my main linux directory to force the modules to show up.

matttbe commented 1 year ago

@dbrouwer3563 thank you for having validated this patch!

Not sure if this is best practice, but I had to manually delete the .virtme_mods folder in my main linux directory to force the modules to show up.

I don't remember I had to do that but when trying to understand the issue, I might have deleted the folder when it was filled in with .o files. Hopefully this fix can get merged before too many users switch to v6.2 and populate the directory with wrong files :-) (cc @amluto)

marcosps commented 1 year ago

@amluto can you please take a look at this PR? Thanks!

arighi commented 1 year ago

This has been merged/fixed in https://github.com/arighi/virtme

NOTE: we are trying to catch up with all the pending PR in this temporary fork. In the future we may merge everything back here if this project become active again, but for now please consider to follow also the development of arighi/virtme.