search

ammar / regexp_parser

A regular expression parser library for Ruby
MIT License
143 stars 22 forks source link

Fix warnings #19

Closed backus closed 8 years ago

backus commented 8 years ago

This PR doesn't fix all warnings, just a warning in expression.rb (which I mentioned in #18) and indentation warnings (mentioned in #10).

backus commented 8 years ago

@ammar could you review this PR?

mbj commented 8 years ago

@ammar To give this a bit of context. Mutant runs itself warning free, including its dependencies, we'd like to keep this property.

ammar commented 8 years ago

@backus Please excuse the delayed response. I just returned from a week of camping (Wadi Rum).

Thanks for this. Definitely something that needs fixing. I have a bit of catch up to do but will review shortly.

ammar commented 8 years ago

There's an extra space in the magic comment, after :false;, but it's still recognized by the ruby parser.

Looks good. Happy this is being fixed, finally.

When I looked at this a while back I used ruby -i -pe, but I prefer the less cryptic open and write approach:

sh "ruby -i -pe 'BEGIN { gets; print \"# -*- warn-indent:false; -*-\n\" + $_ }; ' #{file}"

Planning on releasing a new version, 0.3.4, with a syntax file for ruby 2.3.1. Hopefully in the next couple of days.

Thanks & Cheers

backus commented 8 years ago

Thanks @ammar!

backus commented 8 years ago

Planning on releasing a new version, 0.3.4, with a syntax file for ruby 2.3.1.

Any chance you could release 0.3.4 this week?

ammar commented 8 years ago

0.3.4 was released today.