search

ammar / regexp_parser

A regular expression parser library for Ruby
MIT License
143 stars 22 forks source link

Fix parsing of /\xFF/n (hex:escape) #24

Closed backus closed 8 years ago

backus commented 8 years ago

A previous commit (9803fb2) fixed improper parsing of /\h/ but unintentionally dropped support for multibyte hex escapes.

backus commented 8 years ago

@ammar this is ready for review :smile:.

ammar commented 8 years ago

Excellent. Thanks.

I had a sinking feeling that type/token was in place for a reason. I should have checked the parser tests, or, obviously, lack thereof.

backus commented 8 years ago

Thanks @ammar. Can you release 0.3.5 please?

ammar commented 8 years ago

@backus 0.3.5 is now released. Sorry for not checking the earlier "fix" more closely.

I hope this helps with https://github.com/mbj/mutant/pull/596