ammar / regexp_parser

A regular expression parser library for Ruby
MIT License
143 stars 22 forks source link

Add support for Ruby 2.3.4 version #40

Closed barthez closed 7 years ago

barthez commented 7 years ago

/cc @ammar

Would you mind to release a new version with this fix? I'm working on https://github.com/mbj/mutant/pull/719 and I cannot run CI on Ruby 2.3.4 without this change.

ammar commented 7 years ago

@barthez, Thanks for this. I've been recovering from an accident and just took off my casts and started to catch up with work. I hope to get some time to review this by the coming weekend, at the latest.

barthez commented 7 years ago

No need to rush. I've found a way to run CI on 2.3.3 on mutant repo.

Get well!

ammar commented 7 years ago

Included in release 0.4.4

mbj commented 7 years ago

@barthez Will you do a dependency bump for mutant, or should I take up the stab?

barthez commented 7 years ago

@mbj https://github.com/mbj/mutant/pull/722