search

ammar / regexp_parser

A regular expression parser library for Ruby
MIT License
143 stars 22 forks source link

Support ruby 2.5.0 #49

Closed ammar closed 6 years ago

ammar commented 6 years ago
ammar commented 6 years ago

According to the ruby 2.5.0 release notes the absent group feature was added with the upgrade of Onigmo to version 6.1.3, yet that feature appears to have been added by @janosch-x in #33.

Need to confirm that the feature is indeed added and hasn't changed.

jaynetics commented 6 years ago

Good to go, I'd say!

Nothing notable in the Onigmo HISTORY document.

Also, the Onigmo specs for the absence group feature are quite detailed and haven't changed since it's introduction a year ago (which silently made it into Ruby 2.4.1).

https://github.com/k-takata/Onigmo/blame/b88e88fb740acd2cba0c4e686fe990c3cd73f1ba/testpy.py#L1586

ammar commented 6 years ago

Excellent. Thank you.

I will release 0.4.9 shortly.