Support informal delimiter literals

ammar / regexp_parser

A regular expression parser library for Ruby

MIT License

143 stars 22 forks source link

Support informal delimiter literals #64

Closed ammar closed 4 years ago

ammar commented 4 years ago

Interprets the {, }, and ] delimiters as literals depending on the context.

Notes

Reduce ambiguity in the quantifier_interval pattern by replacing the optional matchers with 4 fixed patterns.
Remove the premature_end_error final state handler from quantifier_interval to permit valid literal sequences.

Closes #63

ammar commented 4 years ago

Thank you for the review. Very helpful.

i've checked some more edge cases and found no issues. maybe we should add one example to spec/parser/quantifiers_spec.rb to document that leading zeros are correctly ignored as in MRI:

include_examples 'quantifier', /a{004}+b/, '{004}+', :possessive, :interval, 4, 4

Good call. I will add it.

I will wrap this up and push out a new release (1.8) this afternoon.

ammar commented 4 years ago

On second thought, I'll consider this a bug fix, and release as 1.7.1.