search

ammar / regexp_parser

A regular expression parser library for Ruby
MIT License
143 stars 22 forks source link

Misc. cleanup #78

Closed dgollahon closed 3 years ago

dgollahon commented 3 years ago

I noticed there was an unused variable in the quantifier spec when I was trying to find a spot to write tests for #77. I think it was meant to be used as an assertion so I added it in the first commit here.

Since I noticed that unused variable by chance, I decided to run rubocop --lint and found a few other minor issues that felt like they might be worth a quick fixup. Feel free to reject these changes or I can drop commits you don't like but I thought they were all small improvements.

You might consider adding a minimal rubocop config with some basic linting and such enabled to avoid small items like these if you like these changes. If you don't, that's fine too.

jaynetics commented 3 years ago

@dgollahon thanks, this is much appreciated! i'll add rubocop one of these days.